Fix 1815 - Get-InstalledPSResource -Path don't throw if no subdirectories were found
#1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-l-a-v
requested review from
SydneyhSmith,
adityapatwardhan,
alerickson and
anamnavi
as code owners
o-l-a-v
changed the title
Get-InstalledPSResource -Path don't throw if no subdirectories were found
alerickson
requested changes
Sep 30, 2025
There was a problem hiding this comment.
The following test is currently failing:
Should not throw on ErrorAction ignore when no subdirectories are found 4ms
ArgumentNullException: Scriptblock not found. Input to 'Throw' and 'Not Throw' must be enclosed in curly braces. (Parameter 'ActualValue')
at Should-Throw, /home/vsts/work/_temp/TempModules/Pester/4.10.1/Functions/Assertions/PesterThrow.ps1: line 35
at <ScriptBlock>, /home/vsts/work/1/s/test/GetInstalledPSResource/GetInstalledPSResource.Tests.ps1: line 157
|
Oops, I enclosed the test in scriptblock now @alerickson. 😊 |
alerickson
approved these changes
Oct 2, 2025
adityapatwardhan
approved these changes
Oct 2, 2025
|
Thanks @o-l-a-v! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Don't throw if no subdirectories are found.
This code is a bit confusing though, I don't get why it searches for version directories with no validation logic.
https://github.com/o-l-a-v/PowerShell--PSResourceGet/blob/3d28924d4d90b05911dc0f1a40bcff14e927dfc0/src/code/GetInstalledPSResource.cs#L101-L111
I won't try to rewrite that, as I'm sure it has a purpose. I'll just make the error non terminating.
PR Context
Closes #1815
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.